Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #90026

Closed
wants to merge 23 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Urgau and others added 23 commits October 14, 2021 01:51
This can append if within the same module a `#[macro_export] macro_rules!`
is declared but also a reexport of itself producing two export of the same
macro in the same module. In that case we only want to document it once.
HermitCore's kernel itself doesn't support TLS.
Consequently, the entries in x86_64-unknown-none-hermitkernel should be removed.
This commit should help to finalize rust-lang#89062.
No functional changes intended.

The LLVM commit
llvm/llvm-project@89b5706
moved TargetRegistry.(h|cpp) from Support to MC.
This adapts RustWrapper accordingly.
…ans, r=estebank"

This reverts commit 36a1076, reversing
changes made to e1e9319.
The affected crates have had plenty of time to update.
By keeping these as lints rather than making them hard errors,
we ensure that downstream crates will still be able to compile,
even if they transitive depend on broken versions of the affected
crates.

This should hopefully discourage anyone from writing any
new code which relies on the backwards-compatibility behavior.
…esleywiser

Make all proc-macro back-compat lints deny-by-default

The affected crates have had plenty of time to update.
By keeping these as lints rather than making them hard errors,
we ensure that downstream crates will still be able to compile,
even if they transitive depend on broken versions of the affected
crates.

This should hopefully discourage anyone from writing any
new code which relies on the backwards-compatibility behavior.
… r=nagisa

RustWrapper: adapt for an LLVM API change

No functional changes intended.

The LLVM commit
llvm/llvm-project@89b5706
moved TargetRegistry.(h|cpp) from Support to MC.
This adapts RustWrapper accordingly.
…laumeGomez

Fix macro_rules! duplication when reexported in the same module

This can append if within the same module a `#[macro_export] macro_rules!`
is declared but also a reexport of itself producing two export of the same
macro in the same module. In that case we only want to document it once.

Before:
```
Module {
    is_crate: true,
    items: [
        Id("0:4"),   // pub use crate::repro as repro2;
        Id("0:3"),   // macro_rules! repro
        Id("0:3"),   // duplicate, same as above
    ],
}
```

After:
```
Module {
    is_crate: true,
    items: [
        Id("0:4"),   // pub use crate::repro as repro2;
        Id("0:3"),   // macro_rules! repro
    ],
}
```

Fixes rust-lang#89852
removing TLS support in x86_64-unknown-none-hermitkernel

HermitCore's kernel itself doesn't support TLS. Consequently, the entries in x86_64-unknown-none-hermitkernel should be removed. This commit should help to finalize rust-lang#89062.
…match-names, r=estebank

Suggest a case insensitive match name regardless of levenshtein distance

Fixes rust-lang#86170

Currently, `find_best_match_for_name` only returns a case insensitive match name depending on a Levenshtein distance. It's a bit unfortunate that that hides some suggestions for typos like `Bar` -> `BAR`. That idea is from rust-lang#46347 (comment), but I think it still makes some sense to show a candidate when we find a case insensitive match name as it's more like a typo.
Skipped the `candidate != lookup` check because the current (i.e, `levenshtein_match`) returns the exact same `Symbol` anyway but it doesn't seem to confuse anything on UI tests.

r? `@estebank`
… r=JohnTitor

Add test for issue rust-lang#84957 - `str.as_bytes()` in a `const` expression

Hi, this PR adds a test for issue rust-lang#84957 . I'm quite new to rustc so let me know if there's anything else that needs doing 😄

Closes rust-lang#84957
…=lnicola

⬆️ rust-analyzer

r? `@ghost`
Revert rust-lang#86011 to fix an incorrect bound check

This reverts commit 36a1076, reversing
changes made to e1e9319.

Fixes rust-lang#89935
r? `@estebank`
@rustbot rustbot added the rollup A PR which is a rollup label Oct 18, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=8

@bors
Copy link
Contributor

bors commented Oct 18, 2021

📌 Commit eccaca0 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 18, 2021
@matthiaskrgr
Copy link
Member Author

some tests are failing locally already :|

failures:
[ui] ui/derives/derives-span-Hash-enum-struct-variant.rs
[ui] ui/derives/derives-span-Hash-enum.rs
[ui] ui/derives/derives-span-Hash-struct.rs
[ui] ui/derives/derives-span-Hash-tuple-struct.rs
[ui] ui/issues/issue-21160.rs
[ui] ui/suggestions/slice-issue-87994.rs
[ui] ui/unique-object-noncopyable.rs

@matthiaskrgr matthiaskrgr deleted the rollup-6l2ix02 branch November 20, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants